nuttxpr commented on PR #15338: URL: https://github.com/apache/nuttx/pull/15338#issuecomment-2561739503
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR likely meets the basic NuttX requirements but is missing crucial information. **Here's why it's borderline and what's missing:** * **Summary:** While it explains the *why* and *what*, it lacks a clear explanation of *how* the fix works. What code was changed to prevent the zero value from being stored? This is the most important part of the summary. * **Impact:** Stating "arm64" is insufficient. It needs to specify: * **Is new feature added? Is existing feature changed?** (This is a bug fix, so existing feature changed) * **Impact on user:** Likely NO, but explicitly state it. * **Impact on build:** Likely NO, but explicitly state it. * **Impact on hardware:** YES, arm64. Be *specific* which arm64 chips/boards are affected. * **Impact on documentation:** Likely NO, but explicitly state it unless documentation was updated to reflect the issue/fix. * **Impact on security:** YES, potentially. Explain the security implications of a null tpidr. A crash due to a null pointer exception is a security issue if it can be triggered by user input or external events. * **Impact on compatibility:** Likely NO, but explicitly state it. * **Testing:** "qemu-armv8a:nsh_smp" is insufficient. Provide: * **Build Host:** Your OS, CPU architecture, compiler, and version. * **MORE detailed Target:** Specify the QEMU version and the exact configuration used. * **Crucially missing: Logs.** There are no "before" and "after" logs demonstrating the fix. This is a critical requirement. Show the error occurring before the fix and the successful operation after the fix. Ideally, the logs should demonstrate the tpidr value being correctly populated. **To make this PR acceptable, you need to add the missing details outlined above. Specifically, clarify *how* the fix works, expand on the impact section answering *all* the questions, and provide detailed build host information and *actual* before/after logs demonstrating the fix.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
