nuttxpr commented on PR #2926: URL: https://github.com/apache/nuttx-apps/pull/2926#issuecomment-2567248450
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does **not** fully meet the NuttX requirements. While it provides some information, it's far too brief and lacks crucial details. Here's why: * **Summary:** "Add depends on" is insufficient. It doesn't explain *what* dependency is added, *why* it's needed, *what* code is changed to add it, or *how* it works. Issue references are also missing. * **Impact:** Simply stating "none" isn't enough. Each impact area needs to be explicitly addressed, even if the answer is "NO". This demonstrates that the contributor has considered the potential impact. If there truly is no impact, briefly explain why (e.g., "Impact on user: NO, this is an internal code change"). * **Testing:** "local test" is inadequate. The specific host and target environments must be listed, along with compiler details. Critically, actual test logs demonstrating the before-and-after behavior are required. "Local test" says nothing about what was tested or the results. To meet the requirements, the PR needs to provide significantly more detail in each section. Vague statements should be replaced with specific information to allow reviewers to understand and evaluate the changes effectively. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
