wangzhi-art commented on code in PR #15345: URL: https://github.com/apache/nuttx/pull/15345#discussion_r1900499104
########## include/nuttx/sched.h: ########## @@ -134,6 +134,7 @@ #define TCB_FLAG_FORCED_CANCEL (1 << 13) /* Bit 13: Pthread cancel is forced */ #define TCB_FLAG_JOIN_COMPLETED (1 << 14) /* Bit 14: Pthread join completed */ #define TCB_FLAG_FREE_TCB (1 << 15) /* Bit 15: Free tcb after exit */ +#define TCB_FLAG_SIGDELIVER (1 << 16) /* Bit 16: Deliver pending signals */ Review Comment: Currently, bit 2 is not used. I don't know if there are other reasons why bit 2 was not used before. If there is no other impact, wouldn't it be better to arrange it more compactly, such as letting TCB_FLAG_POLICY use bits 2-3, TCB_FLAG_CPU_LOCKED use bit 4, and so on? I wonder if this is okay? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
