jasonbu commented on code in PR #15425: URL: https://github.com/apache/nuttx/pull/15425#discussion_r1903563977
########## arch/tricore/include/irq.h: ########## @@ -186,6 +186,13 @@ static inline_function bool up_interrupt_context(void) return ret; } + +/**************************************************************************** + * Name: up_getusrsp + ****************************************************************************/ + +uintptr_t up_getusrsp(void *regs); Review Comment: the current up_getusrsp method in tricore is not good enough, first patch keep the implementation in tricore_registerdump.c, and if we want to move up_getusrsp to irq.h, should move the tricore_csa2addr from internal.h to public header -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
