GUIDINGLI commented on code in PR #15397: URL: https://github.com/apache/nuttx/pull/15397#discussion_r1903552773
########## mm/mm_heap/mm.h: ########## @@ -182,13 +187,18 @@ struct mm_allocnode_s FAR void *backtrace[CONFIG_MM_BACKTRACE]; /* The backtrace buffer for caller */ # endif #endif -}; +}aligned_data(MM_ALIGN); Review Comment: please fix the coding style check ########## mm/kasan/generic.c: ########## @@ -44,10 +45,8 @@ #define KASAN_LAST_WORD_MASK(end) \ (UINTPTR_MAX >> (-(end) & (KASAN_BITS_PER_WORD - 1))) -#define KASAN_SHADOW_SCALE (sizeof(uintptr_t)) - #define KASAN_SHADOW_SIZE(size) \ - (KASAN_BYTES_PER_WORD * ((size) / KASAN_SHADOW_SCALE / KASAN_BITS_PER_WORD)) Review Comment: how about remove KASAN_SHADOW_SCALE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
