nuttxpr commented on PR #15440: URL: https://github.com/apache/nuttx/pull/15440#issuecomment-2574298148
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it mentions the "what" (adding bgra8888 color format support), it lacks crucial details required by the template. Here's a breakdown of what's missing: * **Summary:** Lacks sufficient detail. *Why* is this change necessary? What part of the code is changing? *How* does the bgra8888 support work? Mentioning "for device" isn't helpful; specify the device. Links to related issues are missing. * **Impact:** While it mentions "goldfish gpu fb," this is insufficient. It needs explicit YES/NO answers for *all* impact categories, followed by descriptions where applicable. For instance, does this affect documentation? Compatibility? Security? Even if the answer is NO, stating it explicitly is important. * **Testing:** The information provided is far too vague. "ci & goldfish" doesn't tell us anything useful. Specify the host OS, compiler, target architecture, board configuration, and *provide actual testing logs before and after the change*. Just saying it works isn't enough; demonstrate it with logs. In short, the PR needs significantly more detail to meet the requirements. It needs to be more explicit and provide concrete information for each section of the template. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
