hujun260 commented on code in PR #15429: URL: https://github.com/apache/nuttx/pull/15429#discussion_r1904975342
########## arch/arm/src/armv8-m/arm_ramvec_attach.c: ########## @@ -31,11 +31,18 @@ #include <nuttx/irq.h> #include <nuttx/arch.h> +#include <nuttx/spinlock.h> #include "ram_vectors.h" #ifdef CONFIG_ARCH_RAMVECTORS +/**************************************************************************** + * Private Data + ****************************************************************************/ + +static volatile spinlock_t g_ramvec_lock = SP_UNLOCKED; Review Comment: remove volatile ########## arch/arm/src/armv7-m/arm_ramvec_attach.c: ########## @@ -31,11 +31,18 @@ #include <nuttx/irq.h> #include <nuttx/arch.h> +#include <nuttx/spinlock.h> #include "ram_vectors.h" #ifdef CONFIG_ARCH_RAMVECTORS +/**************************************************************************** + * Private Data + ****************************************************************************/ + +static volatile spinlock_t g_ramvec_lock = SP_UNLOCKED; Review Comment: remove volatile ########## arch/arm/src/armv6-m/arm_ramvec_attach.c: ########## @@ -31,11 +31,18 @@ #include <nuttx/irq.h> #include <nuttx/arch.h> +#include <nuttx/spinlock.h> #include "ram_vectors.h" #ifdef CONFIG_ARCH_RAMVECTORS +/**************************************************************************** + * Private Data + ****************************************************************************/ + +static volatile spinlock_t g_ramvec_lock = SP_UNLOCKED; Review Comment: remove volatile -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
