nuttxpr commented on PR #15449: URL: https://github.com/apache/nuttx/pull/15449#issuecomment-2574748185
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does **not** fully meet the NuttX requirements. While it provides a summary of the change itself, it lacks crucial information required by the template. Here's a breakdown of what's missing: **Summary:** * **Missing Context:** While the summary explains *what* is being done (setting the TCMA flag separately), it doesn't explain *why*. What problem does this solve? What was the previous behavior, and why was it incorrect or undesirable? This is the most critical piece of information missing. * **Missing Scope:** What part of the codebase is affected? Mentioning "arm64_mte.c" is a start, but more detail is needed. Is this related to memory tagging? Which functions are modified? * **Missing Detail:** *How* is the TCMA flag being set separately? What mechanism is used? **Impact:** The entire impact section is placeholder text. Each point needs to be addressed. Even if the impact is "NO" for a particular item, explicitly state it (e.g., "Impact on user: NO"). Don't leave anything ambiguous. Consider these questions: * **User Impact:** Does this change affect any user-facing APIs or behavior? * **Build Impact:** Are any build flags, dependencies, or configurations affected? * **Hardware Impact:** Does this change target specific hardware or affect hardware compatibility? * **Documentation Impact:** Does this change require updates to any documentation? If so, have those updates been made? * **Security Impact:** Does this change have any security implications, positive or negative? * **Compatibility Impact:** Does this change break backward compatibility? Does it affect interoperability with other systems or software? **Testing:** The entire testing section is placeholder text. This is a critical deficiency. Provide specific details: * **Build Host Details:** Specify the OS, CPU architecture, and compiler version used. (e.g., "Linux x86_64, GCC 12.2") * **Target Details:** Specify the target architecture, board, and configuration. (e.g., "QEMU-virt, Cortex-A72, default configuration") * **Testing Logs:** Include *actual* logs from before and after the change. These logs should demonstrate the problem being solved and the successful outcome after applying the change. Simply saying "your testing logs here" is insufficient. Show that the TCMA flag is handled correctly and that the intended behavior is achieved. **In short:** The PR needs significant revision to meet the NuttX requirements. Focus on providing complete and specific information in each section, especially regarding the *why*, *how*, and *impact* of the change, along with clear evidence from testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
