hujun260 commented on code in PR #15426:
URL: https://github.com/apache/nuttx/pull/15426#discussion_r1905460705
##########
arch/arm/src/am335x/am335x_serial.c:
##########
@@ -76,13 +77,14 @@
struct up_dev_s
{
- uint32_t uartbase; /* Base address of UART registers */
- uint32_t baud; /* Configured baud */
- uint32_t ier; /* Saved IER value */
- uint8_t irq; /* IRQ associated with this UART */
- uint8_t parity; /* 0=none, 1=odd, 2=even */
- uint8_t bits; /* Number of bits (7 or 8) */
- bool stopbits2; /* true: Configure with 2 stop bits instead of 1 */
+ uint32_t uartbase; /* Base address of UART registers */
+ uint32_t baud; /* Configured baud */
+ uint32_t ier; /* Saved IER value */
+ uint8_t irq; /* IRQ associated with this UART */
+ uint8_t parity; /* 0=none, 1=odd, 2=even */
+ uint8_t bits; /* Number of bits (7 or 8) */
+ bool stopbits2; /* true: Configure with 2 stop bits instead of 1 */
+ spinlock_t spinlock; /* Spinlock */
Review Comment:
spinlock_t lock;
##########
arch/arm/src/am335x/am335x_i2c.c:
##########
@@ -492,7 +497,7 @@ static inline int am335x_i2c_sem_waitdone(struct
am335x_i2c_priv_s *priv)
uint32_t regval;
int ret;
- flags = enter_critical_section();
+ flags = spin_lock_irqsave(&priv->spinlock);
Review Comment:
will call wait
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
