xiaoxiang781216 commented on code in PR #15444:
URL: https://github.com/apache/nuttx/pull/15444#discussion_r1911883226
##########
libs/libc/Makefile:
##########
@@ -183,6 +183,10 @@ context:: bin kbin
ifeq ($(CONFIG_LIBC_ZONEINFO_ROMFS),y)
$(Q) $(MAKE) -C zoneinfo context BIN=$(BIN)
endif
+ifeq ($(CONFIG_LIBC_MODLIB),y)
Review Comment:
what's about cmake version
##########
libs/libc/modlib/gnu-elf.ld.in:
##########
@@ -18,9 +18,21 @@
*
****************************************************************************/
+
+#include <nuttx/config.h>
+
+#if defined(CONFIG_BUILD_KERNEL) && defined(CONFIG_BINFMT_ELF_EXECUTABLE)
Review Comment:
let's simplify to:
```
#define __ASSEMBLY__
#include <nuttx/addrenv.h>
#ifndef CONFIG_ARCH_TEXT_VBASE
# define CONFIG_ARCH_TEXT_VBASE 0
#endif
SECTIONS
{
.text CONFIG_ARCH_TEXT_VBASE :
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
