nuttxpr commented on PR #15523: URL: https://github.com/apache/nuttx/pull/15523#issuecomment-2587878941
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary. The PR, as described, **partially** meets the NuttX requirements. While it provides a summary and some testing information, it lacks crucial details. Here's what's missing: * **Summary:** While the "what" is stated (adding GD55 support), the "why" and "how" are absent. Why is this support needed? What code changes were implemented to add this support (driver changes, board configuration updates, etc.)? Linking a related NuttX issue would greatly strengthen this section. * **Impact:** While stating "None, other than adding new device support" is a start, it's too broad. Be explicit. Does this impact *any* existing QSPI drivers? Are there any configuration options users need to be aware of? Even if the answer is truly no impact beyond the new device, explicitly stating "No impact on existing QSPI drivers" is better. Also, consider the documentation impact. Does this require documentation updates? * **Testing:** "On a custom board" is insufficient. Provide specifics: * Host OS and toolchain version used for building. * NuttX configuration used on the SAMA5D27C-D1G (e.g., `sama5d27c_som1_ek_defconfig`). * Clear "before" and "after" logs demonstrating the functionality. Ideally, the "before" logs should show the lack of GD55 support (e.g., failure to detect the device), and the "after" logs should show successful detection and basic operation (e.g., reading/writing to the flash). **In short, the PR needs more detail to meet the NuttX requirements fully.** Providing more context and specifics will greatly improve the review process and increase the likelihood of acceptance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
