yf13 commented on code in PR #15527: URL: https://github.com/apache/nuttx/pull/15527#discussion_r1914362921
########## libs/libc/modlib/gnu-elf.ld.in: ########## @@ -26,7 +26,7 @@ # include <nuttx/addrenv.h> # define TEXT CONFIG_ARCH_TEXT_VBASE -# define DATA CONFIG_ARCH_DATA_VBASE + ARCH_DATA_RESERVE_SIZE +# define DATA CONFIG_ARCH_DATA_VBASE + CONFIG_MM_PGSIZE Review Comment: Seems armv7-a still needs ARCH_DATA_RESERVE_SIZE, so we need treat it here. ########## libs/libc/modlib/gnu-elf.ld.in: ########## @@ -26,7 +26,7 @@ # include <nuttx/addrenv.h> # define TEXT CONFIG_ARCH_TEXT_VBASE -# define DATA CONFIG_ARCH_DATA_VBASE + ARCH_DATA_RESERVE_SIZE +# define DATA CONFIG_ARCH_DATA_VBASE + CONFIG_MM_PGSIZE + ARCH_DATA_RESERVE_SIZE Review Comment: As this `gnu-elf.ld.in` is shared among all architectures (as long as the formula is the same), will this keep consistency among them? Also it seems that current armv7-a still needs `ARCH_DATA_VBASE + ARCH_DATA_RESERVE_SIZE`, so we need treat it conditionally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
