wangzhi-art commented on code in PR #15545: URL: https://github.com/apache/nuttx/pull/15545#discussion_r1915900866
########## arch/sim/src/sim/sim_usbdev.c: ########## @@ -347,9 +350,9 @@ static void sim_reqcomplete(struct sim_ep_s *privep, int16_t result) /* Remove the completed request at the head of the endpoint request list */ - flags = enter_critical_section(); + flags = spin_lock_irqsave(&g_sim_usbdev.lock); Review Comment: Because there is only one usbdev instance, g_usbdev.lock, priv->lock, and privep->dev->lock all represent the same lock. I think a unified name would be more convenient, so g_usbdev.lock is used here. Do I need to change it to priv->lock and privep->dev->lock? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
