fdcavalcanti commented on PR #15524: URL: https://github.com/apache/nuttx/pull/15524#issuecomment-2592569131
> > I would like to bring up two to things to our attention. > > > > * I checked other `usbnsh` from other vendors and they take this into consideration (`DEV_CONSOLE` is disabled) > > * STM32F4 has some basic documentation on this already ([items 7 and 8)](https://nuttx.apache.org/docs/latest/platforms/arm/stm32f4/boards/stm32f4discovery/index.html#nsh) > > > > So to answer your question, I think this could be a case of verifying if `CDCACM` and `DEV_CONSOLE` are both enable before registering `/dev/console` in this situation. Maybe have those dependencies documented somewhere? > > I don't find out about cdcacm_initialize in esp32 board code, this issue whether is open /dev/console before cdcacm register? You can adjust them sort to fix this issue? See `/drivers/usbdev/cdcacm.c:2885`, that's where it is initialized, not ESP specific. I think @raiden00pl 's suggestion could work. That would block this from happening without the user ever knowing. A second option would be a compilation warning when both those symbols are defined. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
