yamt commented on PR #15535:
URL: https://github.com/apache/nuttx/pull/15535#issuecomment-2594294205

   > > > > > @yamt the conversion of errno will provide in a new pr soon, so 
let's merge this patch first.
   > > > > 
   > > > > 
   > > > > sorry, i'm against it. your reasoning sounds like "merge changes 
which might break other platforms because it's ok for my platform" to me.
   > > > 
   > > > 
   > > > First, the problem isn't introuced by this patch, but already exist 
from beginning. This patch doesn't make the problem worse, or want to fix it in 
some dirty way. Why do you want or enforce the contributor to fix the unrelated 
thing in one patch or pr? it's strange.
   > > 
   > > 
   > > actually, this patch made the problem worse by changing EBADF to an 
inappropriate error number for non-linux platforms.
   > 
   > EBADF is also wrong on macOS.
   
   it's better because it's at least consistent. i guess it was the intention 
of the original logic.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to