xiaoxiang781216 commented on code in PR #2946:
URL: https://github.com/apache/nuttx-apps/pull/2946#discussion_r1917588376
##########
system/nxrecorder/nxrecorder_main.c:
##########
@@ -531,7 +531,7 @@ static int nxrecorder_cmd_help(FAR struct nxrecorder_s
*precorder,
int main(int argc, FAR char *argv[])
{
- char buffer[LINE_MAX];
+ FAR char *buffer;
Review Comment:
revert the change
##########
netutils/rexec/rexec.c:
##########
@@ -155,9 +155,10 @@ static int do_rexec(FAR struct rexec_arg_s *arg)
int main(int argc, FAR char **argv)
{
- char cmd[LINE_MAX];
struct rexec_arg_s arg;
+ FAR char *cmd;
Review Comment:
revert
##########
system/nxplayer/nxplayer_main.c:
##########
@@ -739,7 +739,7 @@ static int nxplayer_cmd_help(FAR struct nxplayer_s
*pplayer, char *parg)
int main(int argc, FAR char *argv[])
{
- char buffer[LINE_MAX];
+ FAR char *buffer;
Review Comment:
revert
##########
system/trace/trace.c:
##########
@@ -229,7 +229,7 @@ static int trace_cmd_dump(FAR const char *name, int index,
int argc,
static int trace_cmd_cmd(FAR const char *name, int index, int argc,
FAR char **argv, int notectlfd)
{
- char command[LINE_MAX];
+ FAR char *command;
Review Comment:
revert
##########
system/nxlooper/nxlooper_main.c:
##########
@@ -502,7 +502,7 @@ static int nxlooper_cmd_help(FAR struct nxlooper_s
*plooper, char *parg)
int main(int argc, FAR char *argv[])
{
- char buffer[LINE_MAX];
+ FAR char *buffer;
Review Comment:
ditto
##########
system/nxcamera/nxcamera_main.c:
##########
@@ -398,7 +398,7 @@ static int nxcamera_cmd_help(FAR struct nxcamera_s *pcam,
FAR char *parg)
int main(int argc, FAR char *argv[])
{
- char buffer[LINE_MAX];
+ FAR char *buffer;
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
