nuttxpr commented on PR #15579: URL: https://github.com/apache/nuttx/pull/15579#issuecomment-2594587114
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary. This PR does **not** fully meet the NuttX requirements. While it provides a summary of *what* is being changed, it lacks crucial details. Here's what's missing: * **Summary:** * **Why** is this change necessary? What problem does it solve? Is the current errno handling inflexible? How? * **How** exactly does the generation work? Is there a script? Where does the CSV file live? How is it integrated into the build system? * Issue references are missing. Even if there isn't a directly related issue, it's good practice to create one to discuss the proposed change before submitting a PR. * **Impact:** This section is completely empty. All points need to be addressed, even if the answer is "NO". Justify the "NO" answers. For example: "Impact on user: NO. This is an internal change to errno generation and does not affect the API." If the answer is "YES," explain the impact in detail. For instance, will existing user code break? Will new configuration options be added? * **Testing:** * **No build host or target information is provided.** What platforms was this tested on? Be specific (e.g., "Linux, x86_64, GCC 12.1", "sim:qemu-x86_64"). * **No test logs are provided.** Demonstrate that the change works as intended. Show relevant output before and after the change. Even a simple "printf" demonstrating the generated errno values would be helpful. The PR needs to provide significantly more detail to be considered complete. Addressing the above points will make it easier for reviewers to understand and evaluate the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
