anchao commented on PR #15604: URL: https://github.com/apache/nuttx/pull/15604#issuecomment-2601427319
> > > > The advantage of nuttx rtos is that which could run on a chip with a very low frequency (50MHz). On the critical path, we need to further reduce the interference of complex frameworks. You will find that many people in the community are working on inline function and simplifying the function call process. **Each cycle is very important for MCU devices** > > > > > > > > > correctness, simplicity, code size, maintainability, etc are also important. i'm just not convinced this PR provides a better trade-off. maybe you can convince me eg. by providing some numbers. > > > also, i'm not sure about your "too complicated" claim. having a separate fast path seems to make it more complicated to me. > > > > > > I don't have a device and time. I just analyzed the code path and found that the current read/write scenario has additional overhead (uio) compared to the previous one. > > 90% of the business code will not use interfaces like readv/writev. > > while it might be true fro you business code, it depends. some code always use readv/writev. > > > Why do everyone need to use uio to generate additional function calls? (Even iov_iter in Linux read/write path is also unreasonable) > > to have uniform kernel api and eventually reduce code footprint. Let's first discuss https://github.com/apache/nuttx/pull/15603 , which has better branch for write/read and writev/readv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
