yamt commented on PR #15603:
URL: https://github.com/apache/nuttx/pull/15603#issuecomment-2601639703

   > > > > 
[yamt@67c9bc6](https://github.com/yamt/incubator-nuttx/commit/67c9bc6f370eebb80a6a53d4466cd3da170dcf61)
 (not tested at all)
   > > > 
   > > > 
   > > > 
![image](https://private-user-images.githubusercontent.com/758493/404776437-e6c74263-a1d0-489d-b66d-9013e45aadb7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzczNTc5NzAsIm5iZiI6MTczNzM1NzY3MCwicGF0aCI6Ii83NTg0OTMvNDA0Nzc2NDM3LWU2Yzc0MjYzLWExZDAtNDg5ZC1iNjZkLTkwMTNlNDVhYWRiNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMTIwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDEyMFQwNzIxMTBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jMTYxZjVjN2Q0M2RkNzNlNmY0OGVmYzQ5Y2MzN2YxNjQ5ZWZjMGUwOWJlM2I5ODUxZDk5OGY5MGZmYWNhMWZhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.ZsYxM64egWYfzU6F6633WKy6xi7stTNLNleoYVRI3zs)
   > > > The codes in the red line can be skip all
   > > 
   > > 
   > > "if you just want to save a function call for uio_init"
   > 
   > OK, my opinion has not changed, “uio could be skipped when reading and 
writing a single vector buffer“, could we reach a consensus on this option?
   
   i agree it's possible.
   however, i don't agree it's a good trade-off. IMO, unified api matters more 
than a small overhead.
   
   btw, do you have any plans on how preadv/pread would look like with your 
approach?
   (asking because i planned to have a file offset in uio)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to