nuttxpr commented on PR #15614: URL: https://github.com/apache/nuttx/pull/15614#issuecomment-2601798830
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary of the change and lists impacted files, it lacks critical information. Here's what's missing: * **Summary:** Needs more detail. *Why* is this change necessary? What problems did the previous implementation have? What specific resources are being protected? What kind of "small lock" is being used (mutex, semaphore, etc.)? Are there any related issues? * **Impact:** The provided list of files is not sufficient. The PR needs to explicitly answer all the impact questions (user, build, hardware, documentation, security, compatibility) with YES/NO and explanations where necessary. For example, if the answer to "Impact on hardware" is YES, it should specify *which* architectures/boards/drivers are affected (beyond just listing files). Even if the answer is NO for all, it should still explicitly state NO for each. * **Testing:** "CI" is not enough. The PR needs to show *actual* test results, even if simple. "Testing logs before change" and "Testing logs after change" sections should contain demonstrable output that illustrates the problem being solved and the successful application of the fix. What was the behavior before the change? What is the behavior after the change? How do you know the lock is working as intended? What host and target configurations were tested? In short, the PR needs to provide concrete evidence that the change is necessary, correctly implemented, and thoroughly tested. Simply listing files and claiming CI is insufficient for a proper review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
