nuttxpr commented on PR #15613: URL: https://github.com/apache/nuttx/pull/15613#issuecomment-2601995791
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides some information, it lacks crucial details. Here's a breakdown: * **Insufficient Summary:** "Add const to send buffer" is vague. *Which* send buffer? In which file/function/module? *Why* is this const necessary? What problem does it solve (e.g., prevent accidental modification, improve code clarity, enable compiler optimizations)? * **Impact - Missing Details:** Saying "Should not have impact" is not enough. The PR author needs to explicitly answer NO/YES for *each* impact category and provide details where applicable. Even if the impact is minimal, it's important to state that explicitly. The reference to another PR is irrelevant to the impact of *this* PR. * **Testing - Inadequate:** "Build pass locally" is insufficient. What target architecture was tested? What specific tests were run? The provided "testing logs" are empty. The CI dependency is a separate issue and doesn't excuse the lack of local testing evidence in this PR. The author needs to show *how* they tested the change and that it functions correctly. **To make this PR compliant, the author needs to:** 1. **Expand the Summary:** Provide a clear and concise explanation of the change, its purpose, and its location in the codebase. 2. **Complete the Impact Assessment:** Explicitly answer NO/YES for each impact category. Justify the answers. 3. **Provide Meaningful Testing Information:** Specify the build host and target environments, the tests performed, and include relevant *before* and *after* logs demonstrating the change's effect (or lack thereof). Address the CI dependency separately. Only with these additions will the PR meet the NuttX requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
