nuttxpr commented on PR #2961: URL: https://github.com/apache/nuttx-apps/pull/2961#issuecomment-2603451604
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary and describes the impact, it lacks crucial information. Here's what's missing: * **Summary:** While the summary explains *what* is being done, it lacks the *why*. What problem does moving these test folders solve? How does this relate to the linked PR? Is this a cleanup effort? Is it preparing for future work? The summary needs to justify the change. It also needs the corresponding NuttX issue reference if one exists. * **Impact:** While the PR mentions affected files, it doesn't explicitly answer all the required impact questions with YES/NO followed by details if applicable. Even if the answer is NO, stating it explicitly ensures reviewers don't have to guess. For example: * Impact on user: NO * Impact on build: Potentially YES (if any build scripts relied on the old paths. Even if unlikely, this needs to be considered). * Impact on hardware: NO * Impact on documentation: YES (Any documentation referencing these test applications will need updating). * Impact on security: NO * Impact on compatibility: Potentially YES (if external scripts or tools rely on the old paths). * **Testing:** "CI test" is insufficient. The requirements explicitly request testing logs *before* and *after* the change. Even if the CI passes, providing snippets of relevant output demonstrating the tests still function as expected would greatly improve the PR. Also, details of the build host and target are missing. In short, the PR needs more detail and explicit answers to the checklist items to be considered complete. While the changes themselves might be simple, demonstrating due diligence in the PR description is essential for proper review and acceptance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
