nuttxpr commented on PR #2963: URL: https://github.com/apache/nuttx-apps/pull/2963#issuecomment-2604279772
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements as described. While it provides a summary and impact assessment, it lacks crucial information. Here's what's missing: * **Summary:** Lacks clarity on *why* this change is necessary. Simply stating it's part of a larger effort isn't sufficient. What problem does this restructuring solve? How does it benefit the project? What functionality is being changed (even if it's just directory structure)? How *exactly* does the move work (e.g., are symbolic links used? Is it a pure move?). The linked PR provides context, but the PR itself should be self-contained. * **Impact:** While it mentions the affected folders, it lacks crucial "YES/NO" answers for most impact categories. Even if the answer is "NO," it should be explicitly stated. For example: * Impact on user: NO * Impact on build: Potentially YES (if any build scripts rely on the old paths). This needs clarification. * Impact on hardware: NO * Impact on documentation: Potentially YES (if any documentation refers to the old paths). This needs investigation and explicit statement. * Impact on security: NO * Impact on compatibility: Potentially YES. This change *could* break existing user setups or scripts that rely on the old paths. This needs investigation. * **Testing:** "CI test" is insufficient. While CI is important, the PR should provide specific examples of tests run *locally* to validate the change. What were the results before and after the move? Show concrete evidence that the restructuring didn't break anything. Including the build host and target information is also necessary. In short, the PR needs to be more thorough and explicit in addressing all the requirements. It relies too heavily on the linked PR for context. Each PR should stand on its own. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
