nuttxpr commented on PR #15630: URL: https://github.com/apache/nuttx/pull/15630#issuecomment-2604699565
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No. The PR is missing critical information required by the NuttX guidelines. Here's why: * **Insufficient Summary:** While the summary mentions *what* changed (Wireshark usage for USB monitor), it lacks crucial details: * **Necessity:** *Why* is this change needed? What problem does it solve or what improvement does it offer? * **Functionality:** *Which* part of the code is affected? (e.g., USB driver, networking stack, tools) * **Mechanism:** *How* does it work? How is Wireshark integrated? What specific changes were made? * **Issue References:** Are there any related NuttX or NuttX Apps issues this PR addresses? * **Incomplete Impact Assessment:** While "Documentation" is mentioned, other impact categories are not addressed. Even for Documentation, it's insufficient to just say "Documentation." Specify *what* documentation is updated and *how*. All other impact areas (user, build, hardware, security, compatibility) must be explicitly marked as NO or YES, and explained if YES. * **Insufficient Testing Information:** * **Build Host Details:** Missing operating system, CPU architecture, and compiler version used for the build host. * **Target Details:** Missing target architecture, board, and configuration details. * **"CI" is not enough:** While CI passing is good, it's not a replacement for providing specific test logs or results demonstrating the change's functionality *before* and *after* the modification. The provided screenshot doesn't show the *before* state. The PR needs to provide the missing details to be considered complete according to the NuttX requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
