nuttxpr commented on PR #15634: URL: https://github.com/apache/nuttx/pull/15634#issuecomment-2606165013
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides some information, it lacks crucial details. Here's a breakdown of what's missing: * **Summary:** While it states *what* is changed, it doesn't explain *why* (what problem does this solve?). It also lacks detail on *how* the small lock is used. There's no mention of related issues. * **Impact:** The description under "Impact" describes what code is changed, not the *impact* of the change. All the YES/NO questions are unanswered. This is the most significant deficiency. Consider the impact on users, build process, hardware support, documentation needs, security implications, compatibility, etc. Even if the answer is NO, explicitly state it. * **Testing:** Simply stating "CI" is insufficient. Provide specific details about the build host (OS, CPU, compiler version) and target(s) (architecture, board, configuration). The "Testing logs before change" and "Testing logs after change" sections are empty. Real logs demonstrating the issue before the change and the corrected behavior after the change are required. The PR needs to be significantly revised to provide the required information before it can be properly reviewed. Simply listing the requirements and writing one-line descriptions doesn't fulfill the intent of having clear and comprehensive information for reviewers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
