nuttxpr commented on PR #15651: URL: https://github.com/apache/nuttx/pull/15651#issuecomment-2607000342
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No. This PR description does not meet the NuttX requirements. Here's why: * **Insufficient Summary:** The summary needs more detail. While it states *what* is changed, it doesn't adequately explain *why* this change is necessary. What problems did the previous behavior cause? What specific "misusage" are you preventing? What are the benefits of this change? * **Missing Impact Details:** While "arch" is mentioned, the impact section needs to be much more specific. *Which* architectures are affected? Are *all* architectures affected? Will any particular boards or drivers need modification? Explicitly answer the YES/NO questions and provide descriptions. For example: * Impact on hardware (will arch(s) / board(s) / driver(s) change)? YES (This change affects all ARMv7-A architectures. No board or driver modifications are expected.) * **Insufficient Testing Information:** "qemu-armv7a:smp" is not enough. Provide the full build host details (OS, CPU, compiler version). Also, the testing logs sections are empty. You *must* include logs demonstrating the issue before the change and the improved behavior after the change. Simply stating that it "works as intended" is not acceptable. Show how you tested and what the results were. * **Missing Issue References:** Are there any related NuttX issues that prompted this change? If so, those should be linked. **In short, the PR needs to provide more context, be more specific about its impact, and include actual testing logs to demonstrate the fix.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
