anchao commented on code in PR #15604: URL: https://github.com/apache/nuttx/pull/15604#discussion_r1925479268
########## drivers/serial/serial.c: ########## @@ -890,10 +848,11 @@ static int uart_close(FAR struct file *filep) } /**************************************************************************** - * Name: uart_readv + * Name: uart_read Review Comment: Done ########## drivers/serial/serial.c: ########## @@ -1105,7 +1061,7 @@ static ssize_t uart_readv(FAR struct file *filep, FAR struct uio *uio) * return what we have. */ - else if ((filep->f_oflags & O_NONBLOCK) != 0) + else if ((filep->f_oflags & O_NONBLOCK) != 0 || nonblock) Review Comment: Done ########## drivers/serial/serial.c: ########## @@ -1147,7 +1103,7 @@ static ssize_t uart_readv(FAR struct file *filep, FAR struct uio *uio) * wait. */ - else if ((filep->f_oflags & O_NONBLOCK) != 0) + else if ((filep->f_oflags & O_NONBLOCK) != 0 || nonblock) Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org