tmedicci commented on PR #15705: URL: https://github.com/apache/nuttx/pull/15705#issuecomment-2624467782
> I hope you read my reply carefully. Which of the following 2 options do you pick? > > ``` > spin_lock: spin lock > spin_lock_nopreempt: spin_lock + sched_lock > spin_lock_irqsave: spin lock + irq save > spin_lock_irqsave_nopreempt: spin_lock + irq save + sched_lock > ``` > > or > > ``` > spin_lock: spin lock + sched_lock > spin_lock_preempt: spin_lock > spin_lock_irqsave: spin lock + irq save + sched_lock > spin_lock_irqsave_preempt: spin_lock + irq save > ``` In this case, @ xiaoxiang781216, the first option is more intuitive. We can improve the documentation and let it clear that `spin_lock` should not be used when the scheduler and IRQ handler are enabled. It's still usable for our bootloader (for instance). Keeping the API coherent seems to be more important in this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
