xiaoxiang781216 commented on code in PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#discussion_r1942576398


##########
Documentation/platforms/arm/samv7/boards/samv71-xult/README.txt:
##########
@@ -1819,10 +1819,10 @@ Configuration sub-directories
          CONFIG_FS_ROMFS=y
          CONFIG_LIBC_ARCH_ELF=y
          CONFIG_MODULE=y
-         CONFIG_LIBC_MODLIB=y
-         CONFIG_MODLIB_ALIGN_LOG2=2
-         CONFIG_MODLIB_BUFFERINCR=32
-         CONFIG_MODLIB_BUFFERSIZE=128
+         CONFIG_LIBC_LIBELF=y
+         CONFIG_LIBELF_ALIGN_LOG2=2

Review Comment:
   ```suggestion
            CONFIG_LIBc_ELF_ALIGN_LOG2=2
   ```



##########
Documentation/applications/examples/module/index.rst:
##########
@@ -55,8 +55,8 @@ configuration options:
 
 6. Linker scripts. You might also want to use a linker scripts to combine
    sections better. An example linker script is at
-   ``nuttx/libc/modlib/gnu-elf.ld``. That example might have to be tuned for 
your
+   ``nuttx/libc/libelf/gnu-elf.ld``. That example might have to be tuned for 
your

Review Comment:
   could we name it elf?
   ```
      ``nuttx/libc/elf/gnu-elf.ld``. That example might have to be tuned for 
your
   ```



##########
Documentation/platforms/arm/samv7/boards/samv71-xult/README.txt:
##########
@@ -1819,10 +1819,10 @@ Configuration sub-directories
          CONFIG_FS_ROMFS=y
          CONFIG_LIBC_ARCH_ELF=y
          CONFIG_MODULE=y
-         CONFIG_LIBC_MODLIB=y
-         CONFIG_MODLIB_ALIGN_LOG2=2
-         CONFIG_MODLIB_BUFFERINCR=32
-         CONFIG_MODLIB_BUFFERSIZE=128
+         CONFIG_LIBC_LIBELF=y

Review Comment:
   ```suggestion
            CONFIG_LIBC_ELF=y
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to