acassis commented on PR #15793: URL: https://github.com/apache/nuttx/pull/15793#issuecomment-2646209437
> Thanks for the advice. I will review the changes now before committing. > > That's why I only wanted to add a few files. > > This is my first change to NuttX that I want to get merged. Thank you! That was a smart approach! Just another suggestion: normally we don't create a new commit with the coding styles fixes, but we squash and merge then in the previous commits. In your case you have two commits with different files modified, so it was better to create then separated and squash each one in the right commit. There is a documentation for the simple case, but I think it could help you: https://nuttx.apache.org/docs/latest/contributing/making-changes.html#how-to-include-the-suggestions-on-your-pull-request -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
