Re: [PR] drivers/thermal: Add support for passive trip point [nuttx]

[via GitHub]

Donny9 commented on code in PR #15811:
URL: https://github.com/apache/nuttx/pull/15811#discussion_r1950473290


##########
drivers/thermal/thermal_core.c:
##########
@@ -893,8 +896,27 @@ void thermal_zone_device_update(FAR struct 
thermal_zone_device_s *zdev)
         }
     }
 
+  /* Update worker invoke delay */
+
+  delay = zdev->params->passive_delay;
+  list_for_every_entry(&zdev->instance_list, pos,
+                       struct thermal_instance_s, zdev_node)
+    {
+      if (zdev->params->trips[pos->trip].type == THERMAL_PASSIVE)
+        {
+          continue;
+        }
+
+      pos->cdev->ops->get_state(pos->cdev, &current);
+      if ((current != 0 && current != THERMAL_NO_TARGET) ||
+          (pos->target != 0 && pos->target != THERMAL_NO_TARGET))
+        {
+          delay = zdev->params->polling_delay;

Review Comment:
   ```suggestion
             delay = zdev->params->polling_delay;
             break;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org