nuttxpr commented on PR #15813: URL: https://github.com/apache/nuttx/pull/15813#issuecomment-2650602509
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not fully meet the NuttX requirements. While it touches on some key points, it lacks crucial details and depth required for a proper review. Here's a breakdown of the deficiencies: * **Summary:** While linking to another PR is helpful, the summary itself should be self-contained. It doesn't clearly articulate *why* protected mode support is necessary (fix, update, new feature). It mentions *what* is changed (qemu-armv7r board), but not *how* it works. * **Impact:** The description is far too brief. It needs to explicitly address *all* listed impact points with "YES/NO" and provide descriptions where applicable. For example: * **Is new feature added?** YES (Protected mode support) * **Impact on user:** Possibly YES (If users rely on certain behaviors of the previous mode, they might need to adapt. This needs clarification). * **Impact on build:** Likely YES (Since this adds a new mode, the build process might be affected. Needs details). * **...all other impact points similarly...** * **Testing:** While mentioning CI checks is good, it lacks crucial details about the local setup. The "checked with qemu-armv7r:pnsh" is vague. What specific tests were performed? What were the expected outcomes? The placeholder "your testing logs here" needs to be replaced with *actual* logs demonstrating the functionality before and after the change, highlighting the improvement/fix. The Build Host details are completely missing. In short, the PR needs significant expansion to meet the requirements. It needs to be more descriptive, provide specific details about the changes, justify the necessity of the changes, and offer comprehensive testing information and logs. Relying solely on a linked PR for context is insufficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
