tmedicci commented on PR #15732: URL: https://github.com/apache/nuttx/pull/15732#issuecomment-2650775403
> Hi @tmedicci thanks for the merge. > > As I am new to NuttX I don't know all the rules, but should I have marked this new feature as `EXPERIMENTAL`? > > I would like to further improve on it and this might require some changes. I don't think so. `EXPERIMENTAL` means it works only on very specific conditions (this is not the case, because this is expected to work only for the Espressif's SoCs) or if the interface is expected to be changed. As the upper-half driver is registers it as a network interface, I don't see any problems if internal features are added or changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org