nuttxpr commented on PR #15817: URL: https://github.com/apache/nuttx/pull/15817#issuecomment-2651865282
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary of the *what* and *why*, it lacks crucial details. Here's a breakdown of what's missing: * **Summary:** * **How does the change exactly work?** It mentions removing the dependency on NSH arch initialization, but doesn't explain *how* it achieves that. Does it involve adding `stm32_bringup.c` files? Modifying existing files? What specific changes are made within those files? * **Impact:** The impact section is far too brief. While it mentions fixing the bringup process, it needs to explicitly address all the points in the template. For example: * **Impact on user:** Even if the answer is NO, it should be stated explicitly. * **Impact on build:** While it mentions "Building," this isn't descriptive. Does the build process change in any way due to the addition/modification of files? * **Impact on hardware:** Which specific STM32L4 boards are affected? * **Impact on documentation:** Does this change necessitate documentation updates? * **Impact on security, compatibility, etc.:** All of these need to be addressed, even if the answer is NO. * **Testing:** * **Build Host(s):** Missing operating system, CPU architecture, and compiler information. * **Target(s):** Missing specific architectures and board configurations tested. * **Testing logs:** Completely empty. Needs to include logs demonstrating the issue *before* the change and the improved behavior *after* the change. "Building" is not a testing log. Show output demonstrating successful bringup. In short, the PR needs to be significantly more detailed to meet the requirements. It needs to clearly explain the technical implementation of the change, thoroughly address all aspects of its impact, and provide concrete evidence of testing on specific platforms. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
