nuttxpr commented on PR #15821: URL: https://github.com/apache/nuttx/pull/15821#issuecomment-2653040516
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a decent summary and testing information, it is lacking in several key areas: * **Impact is incomplete:** The PR only states "sched" which is insufficient. It needs to address *all* the impact points explicitly (YES/NO with explanations): user impact, build impact, hardware impact (specifically mentioning ESP32 issues), documentation impact, security impact, compatibility impact. * **Testing logs are missing:** The PR claims `ostest` passed but doesn't provide the actual logs as requested by the template. "Passed" is not enough; the logs themselves need to be included. * **Clarity on ESP32 Issues:** The PR mentions the feature doesn't work with `esp32-devkitc:smp` and suggests a conditional config. This needs more investigation and a clearer explanation of the problem and proposed solution. Simply saying "Have no idea why" is unacceptable. If the root cause is unknown, it should be explicitly stated that further investigation is needed. * **Missing "Anything else to consider?":** This section should be addressed, even if the answer is "N/A". In short, the PR needs to be more thorough and address all the points in the template explicitly. The missing logs and vague explanation of the ESP32 issue are particularly concerning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
