xiaoxiang781216 commented on code in PR #15815: URL: https://github.com/apache/nuttx/pull/15815#discussion_r1953242553
########## arch/risc-v/src/common/riscv_exception_common.S: ########## @@ -207,25 +207,46 @@ handle_irq: .cfi_offset x2, 8 /* Toolchain not support macro, is REG_X2 * 4 */ .cfi_offset ra, 0 /* Toolchain not support macro, is REG_EPC * 4 */ + REGLOAD ra, REG_EPC(sp) + REGLOAD s0, REG_X8(sp) Review Comment: the change here make the backtrace can go through multiple interrupt stack frame, should be splitted to new patch and give a detailed comment in commit message and code, otherwise few people can understand why waste time to push/pop the register which already saved and may remove them to improve the speed. Actually, it may better to guard by CONFIG_BACKTRACE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
