fdcavalcanti commented on PR #15816:
URL: https://github.com/apache/nuttx/pull/15816#issuecomment-2659292107

   > > > This commit also affects the boards directory. Won't `arch` on the 
title be misleading?
   > > > > please update commit title to arch/xtensa/esp32s3: use common 
Espressif wireless source
   > > 
   > > 
   > > if a commit changes 2 areas I think that it should be spitted in 2 
commits arch and board in this case and submit them both in same PR
   > 
   > Sorry but it does not make sense. See [#15749 
(comment)](https://github.com/apache/nuttx/pull/15749#issuecomment-2648980512).
   > 
   > If we do this separately, it will introduce a broken build in the git 
history.
   
   @jerpelea that first PR I opened (#15749) split changes in arch and board. 
That was deemed not good as it would break the build, since those were two 
heavily integrated commits.
   
   Now this PR is following the expected "don't break the build between 
commits". Do you have any other demands here or can we proceed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to