nuttxpr commented on PR #15847: URL: https://github.com/apache/nuttx/pull/15847#issuecomment-2661022671
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary. No, this PR does not fully meet the NuttX requirements. While it addresses some aspects, it lacks crucial details. Here's a breakdown of what's missing: * **Summary:** While it links to the issue, the summary is too brief. It needs to clearly explain *what* the fix is. Mentioning "can solve that corner case" is vague. Explain exactly what the code change *is*. * **Impact:** "New style errors can be reported" is too generic. Be specific: * **User Impact:** Will users see different error messages? Will this affect any existing user code? * **Build Impact:** Will this change the build process at all? * **Hardware Impact:** Unlikely, but explicitly state "NO". * **Documentation Impact:** Does the documentation need updating to reflect the new error style? * **Security Impact:** Unlikely, but explicitly state "NO". * **Compatibility Impact:** Are there any backward compatibility concerns? Explicitly state "NO" if none. * **Testing:** The testing description is insufficient. * **Build Host(s):** Provide specifics about your build environment (OS, CPU architecture, compiler version). * **Target(s):** Specify the architecture and board configuration you tested on (e.g., `sim:nsh`, `arm:stm32f4discovery`). * **Testing Logs:** The provided logs only show the *error* message. Include logs demonstrating the behavior *before* and *after* the fix. Show that the error is no longer triggered after your change. Ideally, show the corrected code and the output of nxstyle on the corrected code. In short, the PR needs to be significantly more detailed and explicit in all sections to meet the NuttX requirements. Provide concrete information, not just general statements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
