michallenc commented on code in PR #15872: URL: https://github.com/apache/nuttx/pull/15872#discussion_r1961871908
########## arch/arm/src/tiva/common/tiva_pwm.c: ########## @@ -878,5 +909,25 @@ struct pwm_lowerhalf_s *tiva_pwm_initialize(int channel) #endif +#ifdef CONFIG_TIVA_PWM_COMPLEMENTARY_G0 Review Comment: @acassis Good point, I just copied `g_pwm_chan0` and added these complementary changes. This is already in the mainline. Seems like channel's register offset if you look at other channels. ``` #define TIVA_PWMN_BASE (0x40) /* PWMn Base */ #define TIVA_PWMN_INTERVAL (0x40) /* PWMn Interval */ ``` Channels 2 and 3 have `TIVA_PWMN_INTERVAL * 1` etc. It could be omitted for channel 0 and 1, that's true. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org