hartmannathan commented on PR #15847:
URL: https://github.com/apache/nuttx/pull/15847#issuecomment-2671976594
Uh oh... there's a little problem:
```
/work/NuttX/nuttx/sched/sched/sched_reprioritizertr.c:67:2: error: Missing
whitespace after keyword
/work/NuttX/nuttx/sched/sched/sched_reprioritizertr.c:81:2: error: Missing
whitespace after keyword
```
Here, it's incorrectly picking up the substring `switch` in a variable
called `switch_needed`:
```
bool nxsched_reprioritize_rtr(FAR struct tcb_s *tcb, int priority)
{
bool switch_needed;
/* Remove the tcb task from the ready-to-run list.
* nxsched_remove_readytorun will return true if we just
* remove the head of the ready to run list.
*/
switch_needed = nxsched_remove_readytorun(tcb);
/* Setup up the new task priority */
tcb->sched_priority = (uint8_t)priority;
/* Return the task to the specified blocked task list.
* nxsched_add_readytorun will return true if the task was
* added to the new list. We will need to perform a context
* switch only if the EXCLUSIVE or of the two calls is non-zero
* (i.e., one and only one the calls changes the head of the
* ready-to-run list).
*/
switch_needed ^= nxsched_add_readytorun(tcb);
/* If we are going to do a context switch, then now is the right
* time to add any pending tasks back into the ready-to-run list.
*/
if (switch_needed && list_pendingtasks()->head)
{
nxsched_merge_pending();
}
return switch_needed;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
