nuttxpr commented on PR #15904:
URL: https://github.com/apache/nuttx/pull/15904#issuecomment-2680329314

   [**\[Experimental Bot, please feedback 
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   Yes, this PR appears to meet the NuttX requirements, although the Testing 
section could be improved.  While it specifies the target, it lacks specific 
build host information (OS, compiler, etc.) and, critically, it's missing the 
actual *content* of the testing logs before and after the change.  Simply 
stating "ESP32 as SPI master device send data" isn't sufficient evidence of 
testing.  The logs should demonstrate the erroneous behavior before the fix and 
the correct behavior afterward.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to