nuttxpr commented on PR #15908: URL: https://github.com/apache/nuttx/pull/15908#issuecomment-2682056608
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No. The PR description lacks crucial details required by the NuttX guidelines. While it mentions the "what" (GPIO interrupt support for MCX-NXXX), it's missing the "how." Here's what's missing: * **Summary:** * Lacks detail on *how* the interrupt support is implemented. What changes were made to the driver? Were new files added? What specific functions were modified? * Missing any related issue references. * **Impact:** * While it states it's a new feature, it needs to be more specific about the user impact. Will users need to configure anything new in their applications to use this feature? Does it introduce any new Kconfig options? * The other "Impact" sections (build, hardware, documentation, security, compatibility) are simply dismissed with "nothing else is changed." Even if there's no impact, explicitly stating "NO" for each is necessary for a complete PR. * **Testing:** * Insufficient testing details. While it mentions the board used, it doesn't provide: * Build host information (OS, compiler, etc.) * Specific configuration used on the FRDM-MCX236 (e.g., `nsh> gpioinfo`). * The *content* of the "testing logs." Simply saying "ensuring we get an interrupt" is not proof. Show the actual output demonstrating the interrupt functionality. Ideally, this would include output both before and after the change (even if the "before" shows the interrupt not working). In short, the PR needs to be significantly more detailed to meet the NuttX requirements. It should clearly explain the implementation details, explicitly address all impact areas, and provide concrete evidence of testing with relevant logs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
