nuttxpr commented on PR #15925: URL: https://github.com/apache/nuttx/pull/15925#issuecomment-2693697326
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not meet the NuttX requirements. While it provides some information, it lacks crucial details and context required for proper review. Here's a breakdown: * **Summary:** "add cdcacm syslog channel" is insufficient. It needs to explain *why* this change is necessary. Is there a problem the current syslog doesn't address? What are the benefits of using CDCACM? How does it work? What code is changed? Are there related issues? * **Impact:** "syslog cdcacm" is vague. This section needs YES/NO answers for each item, followed by detailed explanations for any "YES" responses. For example: * **Impact on user:** YES (Users will now be able to redirect syslog output over USB CDCACM. This provides a new option for debugging and monitoring.) * **Impact on build:** Potentially YES (if any Kconfig options are added or modified, explain how). * **Impact on hardware:** Possibly YES (Which architectures and boards are affected? Does it require specific hardware support?) * **Impact on documentation:** YES (Documentation needs to be updated to explain how to configure and use the CDCACM syslog channel.) * **Testing:** "selftest" is inadequate. Specify the host OS, CPU architecture, compiler, and version used for testing. List the target architecture, board, and configuration. Provide *actual* logs demonstrating the functionality before and after the change, not just "selftest." The logs should show that the new CDCACM channel works as expected and that existing functionality is not broken. In short, the PR needs substantially more detail and context for each section to be considered complete. It should clearly explain the motivation, implementation, impact, and testing of the change. Following the template more closely, with specific answers and details, is essential for a successful PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
