cederom commented on code in PR #3014: URL: https://github.com/apache/nuttx-apps/pull/3014#discussion_r1977531483
########## benchmarks/cyclictest/cyclictest.c: ########## @@ -479,6 +487,7 @@ static void *testthread(void *arg) struct thread_param_s *param = (struct thread_param_s *)arg; struct thread_stats_s *stats = param->stats; + stats->tid = gettid(); Review Comment: My bad, you extended the structure, sorry for the noise :-P ########## benchmarks/cyclictest/cyclictest.c: ########## @@ -479,6 +487,7 @@ static void *testthread(void *arg) struct thread_param_s *param = (struct thread_param_s *)arg; struct thread_stats_s *stats = param->stats; + stats->tid = gettid(); Review Comment: Are you sure this `stats->tid` is correct here not `int tid` declared on line 125 or `stats->id`? `struct thread_stats_s *stats` definition contains `pthread_t id;` (line 122) but not `tid`, look https://github.com/apache/nuttx-apps/blob/036fe7668d81a02a9dc32cc18c31a8d74ee6fa4a/benchmarks/cyclictest/cyclictest.c#L122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
