nuttxpr commented on PR #15958: URL: https://github.com/apache/nuttx/pull/15958#issuecomment-2709219914
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary of the *what*, it lacks crucial details about *why* and *how*. The testing section is also insufficient. Here's a breakdown of the missing information: * **Summary:** * **Missing "Why":** The PR states *why* the change is technically possible ("not need to allocate two times"), but doesn't explain the benefit. Why is allocating twice a problem? Does it waste memory? Cause a bug? Improve performance? This context is critical for reviewers. * **Missing "How":** "merge composite instance allocate to one times" is vague. *How* was this merging accomplished? What code was changed? What was the original allocation strategy, and what is it now? * **Missing Related Issues:** Are there any related issues in either the NuttX or NuttX Apps repositories? Even if there aren't, explicitly stating "None" is helpful. * **Impact:** * **Too Brief:** Simply stating "N/A" is insufficient. Even if there's no user-facing impact, build impact, etc., it's important to explicitly state "NO" for each category. This confirms that the contributor considered these aspects. * **Testing:** * **Missing Build Host Information:** What system was this tested on? (OS, CPU architecture, compiler) * **Missing Target Information:** What architecture and board configuration was used? "sim", "RISC-V", "ARM" are just architecture families. Specific boards/configurations are needed. * **Missing "Before" Logs:** There are no "before" logs, making it impossible to assess the impact of the change. * **Vague "After" Logs:** "playback music" is not a helpful log. What should the logs show to demonstrate that the change works correctly? Specific output, error messages, or performance metrics are needed. **In short, the PR needs more detail and concrete evidence of testing to be considered complete.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
