eren-terzioglu opened a new pull request, #16012:
URL: https://github.com/apache/nuttx/pull/16012

   ## Summary
   
   <!-- This field should contain a summary of the changes. It will be 
pre-filled with the commit's message and descriptions. Adjust it accordingly -->
   
   * arch/xtensa/esp32s3: Change default pins for esp32s3-lcd-ev-board v1.5
   
   Change default pins for esp32s3-lcd-ev-board to prevent pin changes between 
boards
   
   * boards/xtensa/esp32s3: Add version support for esp32s3-lcd-ev boards
   
   Add version support for esp32s3-lcd-ev boards to prevent pin changes
   
   ## Impact
   <!-- Please fill the following sections with YES/NO and provide a brief 
explanation -->
   
   Impact on user: No, current applications won't got effected
   
   Impact on build: No, current applications can work fine
   
   Impact on hardware: Yes, new version of esp32s3-lcd-ev board supported
   
   Impact on documentation: No
   
   Impact on security: No
   
   Impact on compatibility: No, older version can be used
   
   ## Testing
   <!-- Please provide all the testing procedure. Consider that upstream 
reviewers should be able to reproduce the same testing performed internally -->
   
   ### Building
   
   Note: You need to change defconfigs with never chips by replacing 
`CONFIG_ARCH_CHIP_ESP32S3WROOM2N16R8V=y` to 
`CONFIG_ARCH_CHIP_ESP32S3WROOM1N16R16V=y` in 
`boards/xtensa/esp32s3/esp32s3-lcd-ev/configs/lvgl/defconfig` or similar, 
otherwise defaults values won't be applied due to Kconfig.
   
   Command used for esp32s3-lcd-ev v1.5 board
   
   ```
   make -j distclean && ./tools/configure.sh esp32s3-lcd-ev:lvgl && 
kconfig-tweak -d CONFIG_ARCH_CHIP_ESP32S3WROOM2N16R8V && kconfig-tweak -e 
CONFIG_ARCH_CHIP_ESP32S3WROOM1N16R16V && kconfig-tweak --set-val 
CONFIG_ESP32S3_I2C0_SCLPIN 48 &&  kconfig-tweak --set-val 
CONFIG_ESP32S3_I2C0_SDAPIN 47 && kconfig-tweak --set-val 
CONFIG_ESP32S3_LCD_DATA6_PIN 8 && kconfig-tweak --set-val 
CONFIG_ESP32S3_LCD_DATA7_PIN 18 && make olddefconfig && make flash 
ESPTOOL_BINDIR=./ ESPTOOL_PORT=/dev/ttyUSB0 -s -j$(nproc) && minicom
   ```
   
   ### Running
   
   `lvgldemo` command run
   
   ### Results
   
   LVGL demo opens and runs
   
   Note: To check everything is working fine for older defconfigs I used this 
steps:
   
   ```
   $ git checkout feature/esp32s3_lcd_ev_v1_5
   $ make -j distclean && ./tools/configure.sh esp32s3-lcd-ev:lvgl
   $ cp .config test
   $ make -j distclean
   $ git checkout master
   $ make -j distclean && ./tools/configure.sh esp32s3-lcd-ev:lvgl
   $ diff -y --color --suppress-common-lines .config test
   
                                                              > # 
CONFIG_ARCH_CHIP_ESP32S3WROOM1N16R16V is not set
                                                              > # 
CONFIG_ESP32S3_PSRAM_16M is not set
                                                              > 
CONFIG_ESP32S3_LCD_EV_BOARD_V14=y
                                                              > # 
CONFIG_ESP32S3_LCD_EV_BOARD_V15 is not set
   
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to