acassis commented on code in PR #16016: URL: https://github.com/apache/nuttx/pull/16016#discussion_r2003977861
########## arch/xtensa/src/esp32/esp32_sha.c: ########## Review Comment: @tmedicci Wouldn't it better to get ESP32 as more register direct access instead of using the HAL? AFAIK only esp32_userspace_pid.c is using the HAL currently. I suggest keep this driver as he implemented. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
