xiaoxiang781216 commented on code in PR #16073:
URL: https://github.com/apache/nuttx/pull/16073#discussion_r2012726012
##########
include/pthread.h:
##########
@@ -333,25 +333,46 @@ typedef struct pthread_mutex_s pthread_mutex_t;
# endif
#endif
+#ifndef CONFIG_PTHREAD_MUTEX_DEFAULT_PRIO_INHERIT
Review Comment:
let use postive logic
```suggestion
#ifdef CONFIG_PTHREAD_MUTEX_DEFAULT_PRIO_INHERIT
```
##########
include/pthread.h:
##########
@@ -333,25 +333,46 @@ typedef struct pthread_mutex_s pthread_mutex_t;
# endif
#endif
+#ifndef CONFIG_PTHREAD_MUTEX_DEFAULT_PRIO_INHERIT
+# define PTHREAD_MUTEX_DEFAULT_PRIO_INHERIT 0
+#else
+# define PTHREAD_MUTEX_DEFAULT_PRIO_INHERIT SEM_PRIO_INHERIT
+#endif
+
+#ifndef CONFIG_PTHREAD_MUTEX_DEFAULT_PRIO_PROTECT
+# define PTHREAD_MUTEX_DEFAULT_PRIO_PROTECT 0
+#else
+# define PTHREAD_MUTEX_DEFAULT_PRIO_PROTECT SEM_PRIO_PROTECT
+#endif
+
+#define PTHREAD_MUTEX_DEFAULT_PRIO_FLAGS (PTHREAD_MUTEX_DEFAULT_PRIO_INHERIT |
\
+ PTHREAD_MUTEX_DEFAULT_PRIO_PROTECT)
+
+#define PTHREAD_NXMUTEX_INITIALIZER { \
+ NXSEM_INITIALIZER(1,SEM_TYPE_MUTEX | PTHREAD_MUTEX_DEFAULT_PRIO_FLAGS), \
Review Comment:
```suggestion
NXSEM_INITIALIZER(1, SEM_TYPE_MUTEX | PTHREAD_MUTEX_DEFAULT_PRIO_FLAGS),
\
```
##########
include/pthread.h:
##########
@@ -333,25 +333,46 @@ typedef struct pthread_mutex_s pthread_mutex_t;
# endif
#endif
+#ifndef CONFIG_PTHREAD_MUTEX_DEFAULT_PRIO_INHERIT
+# define PTHREAD_MUTEX_DEFAULT_PRIO_INHERIT 0
+#else
+# define PTHREAD_MUTEX_DEFAULT_PRIO_INHERIT SEM_PRIO_INHERIT
+#endif
+
+#ifndef CONFIG_PTHREAD_MUTEX_DEFAULT_PRIO_PROTECT
Review Comment:
ditto
##########
include/pthread.h:
##########
@@ -333,25 +333,46 @@ typedef struct pthread_mutex_s pthread_mutex_t;
# endif
#endif
+#ifndef CONFIG_PTHREAD_MUTEX_DEFAULT_PRIO_INHERIT
+# define PTHREAD_MUTEX_DEFAULT_PRIO_INHERIT 0
+#else
+# define PTHREAD_MUTEX_DEFAULT_PRIO_INHERIT SEM_PRIO_INHERIT
+#endif
+
+#ifndef CONFIG_PTHREAD_MUTEX_DEFAULT_PRIO_PROTECT
+# define PTHREAD_MUTEX_DEFAULT_PRIO_PROTECT 0
+#else
+# define PTHREAD_MUTEX_DEFAULT_PRIO_PROTECT SEM_PRIO_PROTECT
+#endif
+
+#define PTHREAD_MUTEX_DEFAULT_PRIO_FLAGS (PTHREAD_MUTEX_DEFAULT_PRIO_INHERIT |
\
+ PTHREAD_MUTEX_DEFAULT_PRIO_PROTECT)
+
+#define PTHREAD_NXMUTEX_INITIALIZER { \
+ NXSEM_INITIALIZER(1,SEM_TYPE_MUTEX | PTHREAD_MUTEX_DEFAULT_PRIO_FLAGS), \
+ NXMUTEX_NO_HOLDER}
Review Comment:
```suggestion
NXMUTEX_NO_HOLDER}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
