nuttxpr commented on PR #16102: URL: https://github.com/apache/nuttx/pull/16102#issuecomment-2767983462
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements. The summary is clear, the impact is well-described (minimal impact, derived from existing similar targets), and the testing section provides sufficient detail to reproduce the build and verify functionality. The inclusion of CMake configuration and build output is particularly helpful. The "Before Changes" section acknowledges the prior lack of CMake support for this target. It might be even better if a "make" build log _before_ the changes could be provided (even if just to show build failure or its absence) to clearly demonstrate the improvement brought by this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
