XuNeo commented on code in PR #16095:
URL: https://github.com/apache/nuttx/pull/16095#discussion_r2022391385
##########
arch/xtensa/src/common/xtensa_tcbinfo.c:
##########
@@ -36,35 +36,9 @@
static const uint16_t g_reg_offs[] =
{
+ /* In the same order as gdb command "maintenance print remote-registers" */
Review Comment:
It will break coredump if the register layout is different in GDB and
coredump.
It does also happen on x86-64 platform. This can be solved by including more
register info in `g_reginfo(g_reg_offs)`.
What's worse is that different GDB expects different register layout. For
example, xt-gdb and esp32s3-gdb have different register layout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
